fix: add v5 migration to normalize legacy filenames#125
Merged
Conversation
Old database entries store filenames as missionname.json which causes double extensions (missionname.json.json.gz) when loading or converting. Normalize filenames when reading from the database so all consumers (handlers, converter, cleanup) get clean base names.
Replace runtime normalizeFilename workaround with a proper database migration that strips .json and .json.gz suffixes from filenames at startup. This fixes old database entries that caused double extensions (missionname.json.json.gz) when loading or converting missions.
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.jsonand.json.gzsuffixes from filenames at server startupmissionname.json, causing double extensions (missionname.json.json.gz) when loading or converting missionsTest plan
TestMigrationV5NormalizeFilenamesthat creates a pre-v5 database with legacy filenames and verifies they are normalized after migrationTestMigrationRerunto expect version 5